-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Extract interpreter workflow and split std_spec
execution
#13267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several naming suggestions
@@ -0,0 +1,64 @@ | |||
name: Interpreter Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming suggestion to keep consistency with the rest of the workflows.
name: Interpreter Test | |
name: Interpreter CI |
SPEC_SPLIT_DOTS: 160 | ||
|
||
jobs: | ||
test-interpreter_spec: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming consistency-wise:
test-interpreter_spec: | |
test-interpreter-spec: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec suite that's being run is called interpreter_spec
.
runs-on: ubuntu-22.04 | ||
container: | ||
image: crystallang/crystal:1.7.3-build | ||
name: "Test Interpreter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd avoid redundant naming (workflow name points at the Interpreter already)
name: "Test Interpreter" | |
name: Test |
runs-on: ubuntu-22.04 | ||
container: | ||
image: crystallang/crystal:1.7.3-build | ||
name: Build interpreter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
name: Build interpreter | |
name: Build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test_interpreter
is failing almost constantly in CI due to running out of memory.Execution of
interpreter-std_spec
uses almost 10G memory, but the GHA runners only have around 8G available.Splitting the entire spec suite into separate pieces reduces the total amount of memory. We already have the mechanism with
SPEC_SPLIT
available. It was previously used for CI on x86.We should probably try to reduce the interpreters memory usage, but this is a quick workaround to get CI green again.