Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up .gitignore #13241

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Conversation

straight-shoota
Copy link
Member

  • Removes a bunch of paths from .gitignore that are not used anymore.
  • Adds .junit (CI artifact)
  • Orders the entries

@@ -1,17 +1,14 @@
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not related to the project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're on macOS you should put that in your global gitignore. It doesn't make sense to have such generic exclusions in every project's gitignore.

@straight-shoota straight-shoota added this to the 1.8.0 milestone Mar 29, 2023
@straight-shoota straight-shoota merged commit 38155d1 into crystal-lang:master Mar 30, 2023
@straight-shoota straight-shoota deleted the fix/gitignore branch March 30, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants