Remove __declspec(dllimport)
from Windows libiconv build
#13219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libiconv static library we build for our Windows packages apparently tries to import
libiconv_version
from the libiconv DLL, so almost every program built on Windows behaves like a DLL that depends on libiconv, producing messages similar to the following during compilation:This PR fixes it by removing this hardcoded
__declspec(dllimport)
added when that third-party repository upgraded libiconv from 1.16 to 1.17, introduced via #12745. (This__declspec
is never a good idea in the first place because MSVC would warn about conflicting keywords when building a libiconv DLL.)