Remove pending spec for Path#drive with IPv6 UNC host names
#13190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
platform:windows
straight-shoota
approved these changes
Mar 15, 2023
Sija
reviewed
Mar 17, 2023
| # The first component is either an IPv4 address or a hostname. | ||
| # IPv6 addresses are converted into hostnames by replacing all `:`s with | ||
| # `-`s, and then appending `.ipv6-literal.net`, so raw IPv6 addresses cannot | ||
| # appear here. |
There was a problem hiding this comment.
I'd suggest adding an example to clearly illustrate the conversion.
There was a problem hiding this comment.
This is a purely informational explanation why there is no need to consider IPv6 addresses specifically. For our purposes, they are just regular host names. We're not doing any such conversion ourselves and details of the external conversion are irrelevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The given
\\2001:4860:4860::8888\share\is an invalid UNC string, as IPv6 addresses should be represented like\\2001-4860-4860--8888.ipv6-literal.net\share\instead. No further action is necessary asPathdoesn't have methods to convert the UNC host name into aSocket::IPAddress, even for the IPv4 case.