Fix type names for generic instances with empty splat type vars #13189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where if a generic type has at least one splat type variable and one non-splat type variable, and a generic instance has zero type arguments corresponding to the splat, that instance's type name includes an extra comma:
In particular, if the splat is not the last variable of the generic type, the resulting type name is syntactically invalid. This shows up everywhere, from macro interpolations like above to
Class#name
and error messages.Tuple
andProc
, the only two built-in variadic generics, overrideCrystal::Type#to_s_with_options
, so they are immune from this.