-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LLVM 16 #13181
Support LLVM 16 #13181
Conversation
42af62e
to
ca340f0
Compare
This workaround: crystal/.github/workflows/win.yml Lines 309 to 313 in 3a360b1
is also unnecessary for LLVM 16 due to https://reviews.llvm.org/rG36357c967cdb9006dd7de9be0dd52068da2a4f96 |
🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
It looks like both the 16.0.2 and 16.0.3 packages work. I could reproduce the crash locally with 16.0.0 but still have no clue what was going on. C++ ABI mismatch...? EDIT: it is probably due to a missing |
llvm_ubuntu_version: "18.04" | ||
- llvm_version: "15.0.6" | ||
llvm_ubuntu_version: "18.04" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these in 18.04? Don't they work in 20.04? 18.04 is close to EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the version number that comes with the LLVM download, our base image is now always 22.04
Tested on x86_64-linux-gnu for some build between 16.0.0-rc3 and rc4 only. No changes were required in the compiler at all because we already switched to opaque pointers for LLVM 15.
This does not include the debug information stuff in #13174.