Implement Process.ppid on Windows
#13140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
platform:windows
Sija
reviewed
Mar 2, 2023
| @@ -37,6 +37,10 @@ class Process | |||
| end | |||
|
|
|||
| # Returns the process identifier of the parent process of the current process. | |||
| # | |||
| # On Windows, the parent is associated only at process creation time, and the | |||
There was a problem hiding this comment.
Suggested change
| # On Windows, the parent is associated only at process creation time, and the | |
| # NOTE: On Windows, the parent is associated only at process creation time, and the |
|
@HertzDevil #13131 is merged, so the spec can be enabled. I suppose the double exclusion from |
straight-shoota
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The affected spec is still pending because it uses the
Signal::KILLstub, which is removed as part of #13131.Also note that since Windows does not re-parent orphaned processes, it is entirely possible for those parent-child IDs to form loops.