Handle ARM64 MSVC paths when cross-compiling on Windows #13073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
topic:compiler
platform:windows
straight-shoota
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the proper directories for both ARM64 Windows hosts and targets, and also builds our custom LLVM with ARM64 support. These small changes allow an x86-64 Windows Crystal emulated on an ARM64 Windows machine to cross-compile to the
aarch64-windows-msvctarget, using the correctcl.exeand library directories in the emitted linker command. (This kind of cross-compilation is already doable on any host machine where LLVM was built with AArch64 support, except that the linker command won't include any full paths on non-Windows hosts.)There is no
src/lib_c/aarch64-windows-msvcin this PR, because there are definitely architecture-specific components such as stack unwinding that aren't as simple as this PR.Those paths are verified on an ARM64 Windows 11 development virtual machine running on UTM under an Apple M2.