Error when find-llvm-config
is unsuccessful
#13045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
find-llvm-config
can't find an LLVM installation, it silent about it, print nothing and exiting as success. This results in undecipherable errors later on whenLibLLVM::LLVM_CONFIG
is called.This patch changes the helper to error with status 1 and print an informative message to stderr if
LLVM_CONFIG
was not found.Before:
After:
Resolves https://forum.crystal-lang.org/t/problem-compiling-crystalline-for-the-vscode-plugin/5316