-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: refactor test recipe #12979
Makefile: refactor test recipe #12979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makefile.win
needs the same changes
Why the name By the way, I used to use |
@asterite The idea for renaming is to make clear that it does something different than In any case, |
Oh, then I'm confused. What does |
b050893
to
1f74fa4
Compare
The Then it's probably better to define |
I don't understand why we can't change |
Like I said in #12979 (comment) the idea was to make |
What would be the dangers of naming it
With this change, if some packages relied on |
Okay, let's keep the name I'll still keep |
The
spec
recipe buildsspec/all_spec.cr
which combinesstd_spec
,compiler_spec
andprimitives_spec
into a single spec suite. This is huge and requires a lot of resources, both for building as well as running the specs. It can easily exhaust many build system's memory capabilities.I don't think we're using it anywhere whatsoever. And it's really not recommended due to the intense resource requirements.
But since it's there and mentioned as the top test recipe, users (especially package maintainers) are likely to pick it up.
This patch includes the following changes:
spec
toall_spec
and add a note that it's expensive.test
as a replacement which runs the parts (std_spec
,compiler_spec
andprimitives_spec
) individually.