Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove verbose=1 in test_llvm #12931

Merged

Conversation

straight-shoota
Copy link
Member

This seems to be a debugging artifact. There's way too much output to be useful for anything.

@straight-shoota straight-shoota added this to the 1.8.0 milestone Jan 11, 2023
@HertzDevil
Copy link
Contributor

HertzDevil commented Jan 11, 2023

I haven't seen this error before: https://github.com/crystal-lang/crystal/actions/runs/3886325401/jobs/6631288655#step:5:348

I run the stdlib specs locally with the same seed but couldn't reproduce it. Might be an arch-specific thing?

@straight-shoota
Copy link
Member Author

straight-shoota commented Jan 11, 2023

It's likely a fluke. I'm rerunning the failed jobs in CI and trying the same seed locally.

This failure is definitely unrelated to this PR though.

@straight-shoota
Copy link
Member Author

It actually reproduces with the same seed. So seems to be some interference between specs. I'll look into it. Shouldn't stop this PR though.

@straight-shoota
Copy link
Member Author

straight-shoota commented Jan 11, 2023

Found and fixed: #12941

@HertzDevil You probably got a different order despite the same seed because some specs only exist on Linux, others only on macOS.

@straight-shoota straight-shoota merged commit 1273855 into crystal-lang:master Jan 12, 2023
@straight-shoota straight-shoota deleted the chore/ci-remove-verbose branch January 12, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants