Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter checks for multiple assignment syntax #12919

Merged

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Jan 8, 2023

Fixes #11442. Fixes #12911.

Also disallows the following:

# block in setter method target without receiver, ignored by parser
a {}, b = ...

# block in setter method target with receiver, ignored by literal expander
a.b {}, c = ...

# empty parentheses in setter method target with receiver, ignored by parser
a.b(), c = ...

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser labels Jan 8, 2023
@straight-shoota straight-shoota added this to the 1.8.0 milestone Jan 9, 2023
@straight-shoota straight-shoota merged commit 787d729 into crystal-lang:master Jan 11, 2023
@HertzDevil HertzDevil deleted the bug/multi-assign-syntax branch January 11, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser
Projects
None yet
2 participants