Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatter empty array literal with comment on extra line #12907

Conversation

straight-shoota
Copy link
Member

Fixes #12841

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Jan 6, 2023
@straight-shoota straight-shoota self-assigned this Jan 6, 2023
@straight-shoota straight-shoota force-pushed the fix/formatter-array-literal-comment branch from d5e797d to 01aaf2d Compare January 6, 2023 11:30
@straight-shoota straight-shoota force-pushed the fix/formatter-array-literal-comment branch from 01aaf2d to 607a899 Compare January 6, 2023 11:32
@beta-ziliani beta-ziliani added this to the 1.8.0 milestone Feb 1, 2023
@straight-shoota straight-shoota merged commit 6d37cc4 into crystal-lang:master Feb 2, 2023
@straight-shoota straight-shoota deleted the fix/formatter-array-literal-comment branch February 2, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatter: Allow empty arrays containing comments on newlines
2 participants