Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unwrap nested errors in error handler for Crystal::Error #12888

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/compiler/crystal/command.cr
Original file line number Diff line number Diff line change
@@ -141,6 +141,14 @@ class Crystal::Command
rescue ex : Crystal::Error
report_warnings

# This unwraps nested errors which could be caused by `require` which wraps
# errors in order to trace the require path. The causes are listed similarly
# to `#inspect_with_backtrace` but without the backtrace.
while cause = ex.cause
error ex.message, exit_code: nil
ex = cause
end

error ex.message
rescue ex : OptionParser::Exception
error ex.message