Order _
after any other Path
when comparing overloads
#12855
Merged
+69
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12854. The snippet there now produces the same overload order whether
-Dpreview_overload_order
is defined or not (but as shown there this bugfix isn't limited to the behavior of that flag).This happens because
Crystal::Path#restriction_of?(other, ...)
incorrectly overridesCrystal::ASTNode#restriction_of?(other : Underscore, ...)
; the PR adds the corresponding overloads inPath
and other node types that do the same thing.