Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting #12405 Compiler: don't always use Array for node dependencies and observers #12849

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

beta-ziliani
Copy link
Member

Reverts #12405
Solves #12769

@beta-ziliani beta-ziliani added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:interpreter labels Dec 16, 2022
@beta-ziliani beta-ziliani added this to the 1.7.0 milestone Dec 16, 2022
@straight-shoota straight-shoota merged commit 8825501 into crystal-lang:master Dec 17, 2022
@straight-shoota straight-shoota added the kind:regression Something that used to correctly work but no longer works label Dec 17, 2022
@straight-shoota
Copy link
Member

This change should probably be brought back eventually. That's tracked in #12851.

@straight-shoota straight-shoota linked an issue Dec 17, 2022 that may be closed by this pull request
carlhoerberg pushed a commit to carlhoerberg/crystal that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:compiler:interpreter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpreter broken on master when exiting naturally
3 participants