Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Def#yields to Def#block_arity #12833

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Rename Def#yields to Def#block_arity #12833

merged 1 commit into from
Dec 13, 2022

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Dec 11, 2022 •
edited
Loading

The property name Def#yields is ambiguous and confusing.

This patch renames it to block_arity which is a better description of what it represents.

@straight-shoota straight-shoota added this to the 1.7.0 milestone Dec 12, 2022
@straight-shoota straight-shoota merged commit eb1ebb4 into crystal-lang:master Dec 13, 2022
@straight-shoota straight-shoota deleted the refactor/def-block_arity branch December 13, 2022 10:36
carlhoerberg pushed a commit to carlhoerberg/crystal that referenced this pull request Dec 21, 2022
@straight-shoota @carlhoerberg
Rename Def#yields to Def#block_arity (crystal-lang#12833)
464089b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:compiler:parser
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @asterite