Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restriction of numeral generic argument against non-free variable Path #12784

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Fix restriction of numeral generic argument against non-free variable Path #12784

merged 5 commits into from
Dec 5, 2022

Conversation

HertzDevil
Copy link
Contributor

Fixes #11859.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:generics labels Nov 27, 2022
@HertzDevil HertzDevil changed the title Do not restrict numeral generic arguments against Paths as free variables Fix restriction of numeral generic argument against non-free variable Path Nov 27, 2022
@HertzDevil HertzDevil marked this pull request as draft November 27, 2022 13:05
sdogruyol
sdogruyol approved these changes Nov 27, 2022
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HertzDevil 🙏

@HertzDevil HertzDevil marked this pull request as ready for review December 2, 2022 13:39
@straight-shoota straight-shoota added this to the 1.7.0 milestone Dec 2, 2022
@straight-shoota straight-shoota merged commit 33b1920 into crystal-lang:master Dec 5, 2022
@HertzDevil HertzDevil deleted the bug/single-path-generic-arg-num branch December 8, 2022 20:47
@BlobCodes BlobCodes mentioned this pull request Feb 25, 2023
Closed
@HertzDevil HertzDevil mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:generics
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Generics do not restrict integer parameters in method calls
3 participants
@HertzDevil @straight-shoota @sdogruyol