Add HTTP::Headers#serialize
#12765
Merged
Add HTTP::Headers#serialize
#12765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An http request has a method to_io to serialize its data. I wonder if we should eventually unify those names. Serialize is probably better than to_io. Alternative we could try to come up with a more descriptive name. |
sdogruyol
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method serializes the headers in the format used in HTTP. The implementation already existed in
HTTP.serialize_headers, this just moves it toHTTP::Headers. That's a more fitting place. It's easier to find and use.As a consequence
HTTP.serialize_headersgets deprecated.