Fix OpenSSL::SSL::Context::Client#alpn_protocol=
#12724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11895
The current
OpenSSL::SSL::Context#alpn_protocol=
setter callsLibSSL.ssl_ctx_set_alpn_select_cb
, which only works for server SSL contexts. This PR moves this setter into theContext::Server
subclass, and adds aContext::Client#alpn_protocol=
setter that calls the correctLibSSL.ssl_ctx_set_alpn_protos
method for client contexts.