Couple of ameba lint issues fixed #12685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops the redundant `is_` prefix from the name.
Sija
force-pushed
the
couple-of-ameba-lint-issues-fixed
branch
from
fcceb5a to
dbeb635
Compare
straight-shoota
approved these changes
Oct 29, 2022
Sija
force-pushed
the
couple-of-ameba-lint-issues-fixed
branch
from
81fa9bb to
4f58684
Compare
|
I've pushed couple of other small refactors and reverted one that broke the interpreter spec - didn't seem legit to me though - looked like if the type system wasn't messing up the type filtering 🤔 no more unintended changes, leaving it in peace for the review. |
straight-shoota
requested changes
Oct 30, 2022
This reverts commit 176ebea.
straight-shoota
approved these changes
Nov 18, 2022
oprypin
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes couple of fixes of the issues found by the ameba linter.
I've opted to group them in a single PR to avoid spamming the repo with multiple tiny PRs.