Style: Remove explicit returns from the codebase #12637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Oct 20, 2022
beta-ziliani
approved these changes
Nov 10, 2022
Comment on lines
212
to
+213
| global = ensure_class_var_in_this_module(global, class_var) | ||
| return global | ||
| global |
There was a problem hiding this comment.
The global assignment and return is unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes explicit returns from the codebase.
One small step towards making the codebase linter friendly.
Also harmless to keep them in.
This is part of a handful of small PRs, each focussing on a single style issue that is unlikely to be found in other Crystal projects as they are picked up by the widely used ameba linter