Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shell.nix for newer LLVM versions and aarch64-darwin #12591

Merged
merged 4 commits into from
Nov 17, 2022

Conversation

HertzDevil
Copy link
Contributor

No description provided.

Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, you got it working after I failed to upgrade to anything newer than LLVM 11 in #12498 😆

@HertzDevil HertzDevil added this to the 1.7.0 milestone Oct 14, 2022
@HertzDevil
Copy link
Contributor Author

Does MACOSX_DEPLOYMENT_TARGET also need to be updated?

@beta-ziliani
Copy link
Member

Does MACOSX_DEPLOYMENT_TARGET also need to be updated?

Sounds reasonable, although tbh I don't know what's a sensible X in 11.X

@straight-shoota straight-shoota removed this from the 1.7.0 milestone Oct 24, 2022
@will
Copy link
Contributor

will commented Nov 14, 2022

I've only been using nix for a day, decided to try not using homebrew on a new computer, but this PR worked for me first try

/t/crystal (feature/nix-shell)> nix-shell
these 2 derivations will be built:
  /nix/store/8c5yzvwwd0rz20qnzb8g3p7cxifr30v2-boehm-gc-8.2.0.drv
  /nix/store/a8ml099barsdjffjcxw87wfmqymf9hbk-crystal-binary.drv
these 128 paths will be fetched (168.57 MiB download, 1033.73 MiB unpacked):
...on and on and on....


[nix-shell:/tmp/crystal]$ crystal --version
Crystal 1.6.1 [fc61bd678] (2022-10-21)

LLVM: 10.0.0
Default target: aarch64-apple-darwin

@straight-shoota
Copy link
Member

@HertzDevil @beta-ziliani What needs to be done with regards to MACOSX_DEPLOYMENT_TARGET to move this forward?

@beta-ziliani
Copy link
Member

On a second thought, if we still can compile it in 10.11, I don't see the reason to change it.

@HertzDevil HertzDevil added this to the 1.7.0 milestone Nov 15, 2022
@straight-shoota straight-shoota merged commit 3b2e25b into crystal-lang:master Nov 17, 2022
@HertzDevil HertzDevil deleted the feature/nix-shell branch November 18, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants