Fix building Wasm32 on Crystal 1.6 (Regression) #12580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blacksmoke16
added
kind:bug
straight-shoota
approved these changes
Oct 10, 2022
bcardiff
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #11991 redefined
Crystal::System::FileDescriptor.system_infosuch that it would always fail withNotImplementedError. The original definition from "../unix/file_descriptor" works correcly and there is no need to disable this funcionality.In fact, this change prevents STDOUT, STDERR and STDIN from been created and prevent any Wasm32 program from running 😱.
I already included this particular fix on #12571, and merging that will also prevent errors such as this from happening again. But I'm opening this PR as a regression fix in hope that this can be released as 1.6.1, otherwise WebAssembly will be unusable until 1.7.