Fix crash when using sizeof
, instance_sizeof
, or offsetof
as a type arg
#12577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't prevent using
sizeof
in some cases. Something like this works still:Poking around in the compiler code for the first time, I couldn't see a way to expand this functionality to also work for other cases. And based on comments on the related issues, maybe it doesn't make sense to do so. So I decided to just fix the ugly crash message. I believe this resolves #8858, while leaving #5427 open for future work.
The small parser change just allows the error message to point to the right part of the line, like