Add CHANGELOG for 1.6.0 #12568
Merged
Add CHANGELOG for 1.6.0 #12568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Oct 5, 2022
CHANGELOG.md
Outdated
Comment on lines
55
to
61
| - Replace deprecated `Socket.ip?` with `IPAddress.valid?` ([#12489](https://github.com/crystal-lang/crystal/pull/12489), thanks @straight-shoota) | ||
| - Fix `HTTP::Client#exec` to abort retry when client was closed ([#12465](https://github.com/crystal-lang/crystal/pull/12465), thanks @straight-shoota) | ||
| - Fix specs with side effects ([#12539](https://github.com/crystal-lang/crystal/pull/12539), thanks @straight-shoota) | ||
| - Fix `HTTP::Client` implicit compression with retry ([#12536](https://github.com/crystal-lang/crystal/pull/12536), thanks @straight-shoota) | ||
| - `HTTP::StaticFileHandler`: Reduce max stat calls from 6 to 2 ([#12310](https://github.com/crystal-lang/crystal/pull/12310), thanks @didactic-drunk) | ||
| - Add `Socket::IPAddress.valid?` ([#10492](https://github.com/crystal-lang/crystal/pull/10492), thanks @straight-shoota) | ||
| - Add warning about concurrent requests in `HTTP::Client` ([#12527](https://github.com/crystal-lang/crystal/pull/12527), thanks @straight-shoota) |
There was a problem hiding this comment.
Suggested change
| - Replace deprecated `Socket.ip?` with `IPAddress.valid?` ([#12489](https://github.com/crystal-lang/crystal/pull/12489), thanks @straight-shoota) | |
| - Fix `HTTP::Client#exec` to abort retry when client was closed ([#12465](https://github.com/crystal-lang/crystal/pull/12465), thanks @straight-shoota) | |
| - Fix specs with side effects ([#12539](https://github.com/crystal-lang/crystal/pull/12539), thanks @straight-shoota) | |
| - Fix `HTTP::Client` implicit compression with retry ([#12536](https://github.com/crystal-lang/crystal/pull/12536), thanks @straight-shoota) | |
| - `HTTP::StaticFileHandler`: Reduce max stat calls from 6 to 2 ([#12310](https://github.com/crystal-lang/crystal/pull/12310), thanks @didactic-drunk) | |
| - Add `Socket::IPAddress.valid?` ([#10492](https://github.com/crystal-lang/crystal/pull/10492), thanks @straight-shoota) | |
| - Add warning about concurrent requests in `HTTP::Client` ([#12527](https://github.com/crystal-lang/crystal/pull/12527), thanks @straight-shoota) | |
| - Fix `HTTP::Client#exec` to abort retry when client was closed ([#12465](https://github.com/crystal-lang/crystal/pull/12465), thanks @straight-shoota) | |
| - Fix specs with side effects ([#12539](https://github.com/crystal-lang/crystal/pull/12539), thanks @straight-shoota) | |
| - Fix `HTTP::Client` implicit compression with retry ([#12536](https://github.com/crystal-lang/crystal/pull/12536), thanks @straight-shoota) | |
| - Reduce max stat calls from 6 to 2 in `HTTP::StaticFileHandler` ([#12310](https://github.com/crystal-lang/crystal/pull/12310), thanks @didactic-drunk) | |
| - Add `Socket::IPAddress.valid?` ([#10492](https://github.com/crystal-lang/crystal/pull/10492), ([#12489](https://github.com/crystal-lang/crystal/pull/12489), thanks @straight-shoota) | |
| - Add warning about concurrent requests in `HTTP::Client` ([#12527](https://github.com/crystal-lang/crystal/pull/12527), thanks @straight-shoota) |
There was a problem hiding this comment.
There was a problem hiding this comment.
@beta-ziliani you removed the wrong entry ;)
CHANGELOG.md
Outdated
Comment on lines
120
to
122
| - **(performance)** Compiler: avoid creating `Set` in `merge_if_vars` ([#12433](https://github.com/crystal-lang/crystal/pull/12433), thanks @asterite) | ||
| - Compiler: simplify some calls ([#12417](https://github.com/crystal-lang/crystal/pull/12417), thanks @asterite) | ||
| - **(performance)** Compiler: micro-optimizations in `merge_if_vars` ([#12432](https://github.com/crystal-lang/crystal/pull/12432), thanks @asterite) |
There was a problem hiding this comment.
Suggested change
| - **(performance)** Compiler: avoid creating `Set` in `merge_if_vars` ([#12433](https://github.com/crystal-lang/crystal/pull/12433), thanks @asterite) | |
| - Compiler: simplify some calls ([#12417](https://github.com/crystal-lang/crystal/pull/12417), thanks @asterite) | |
| - **(performance)** Compiler: micro-optimizations in `merge_if_vars` ([#12432](https://github.com/crystal-lang/crystal/pull/12432), thanks @asterite) | |
| - **(performance)** Compiler: avoid creating `Set` in `merge_if_vars` ([#12433](https://github.com/crystal-lang/crystal/pull/12433), thanks @asterite) | |
| - **(performance)** Compiler: micro-optimizations in `merge_if_vars` ([#12432](https://github.com/crystal-lang/crystal/pull/12432), thanks @asterite) | |
| - Compiler: simplify some calls ([#12417](https://github.com/crystal-lang/crystal/pull/12417), thanks @asterite) |
There was a problem hiding this comment.
What's the reasoning here? It looks like just reordering the items?
There was a problem hiding this comment.
yeah, seemed odd to have two entries related to the same part of the codebase separated.
CHANGELOG.md
Outdated
Comment on lines
55
to
61
| - Replace deprecated `Socket.ip?` with `IPAddress.valid?` ([#12489](https://github.com/crystal-lang/crystal/pull/12489), thanks @straight-shoota) | ||
| - Fix `HTTP::Client#exec` to abort retry when client was closed ([#12465](https://github.com/crystal-lang/crystal/pull/12465), thanks @straight-shoota) | ||
| - Fix specs with side effects ([#12539](https://github.com/crystal-lang/crystal/pull/12539), thanks @straight-shoota) | ||
| - Fix `HTTP::Client` implicit compression with retry ([#12536](https://github.com/crystal-lang/crystal/pull/12536), thanks @straight-shoota) | ||
| - `HTTP::StaticFileHandler`: Reduce max stat calls from 6 to 2 ([#12310](https://github.com/crystal-lang/crystal/pull/12310), thanks @didactic-drunk) | ||
| - Add `Socket::IPAddress.valid?` ([#10492](https://github.com/crystal-lang/crystal/pull/10492), thanks @straight-shoota) | ||
| - Add warning about concurrent requests in `HTTP::Client` ([#12527](https://github.com/crystal-lang/crystal/pull/12527), thanks @straight-shoota) |
There was a problem hiding this comment.
CHANGELOG.md
Outdated
Comment on lines
120
to
122
| - **(performance)** Compiler: avoid creating `Set` in `merge_if_vars` ([#12433](https://github.com/crystal-lang/crystal/pull/12433), thanks @asterite) | ||
| - Compiler: simplify some calls ([#12417](https://github.com/crystal-lang/crystal/pull/12417), thanks @asterite) | ||
| - **(performance)** Compiler: micro-optimizations in `merge_if_vars` ([#12432](https://github.com/crystal-lang/crystal/pull/12432), thanks @asterite) |
There was a problem hiding this comment.
What's the reasoning here? It looks like just reordering the items?
CHANGELOG.md
Outdated
| - Execute `compopt` only when it's present ([#12248](https://github.com/crystal-lang/crystal/pull/12248), thanks @potomak) | ||
| - Use `Makefile.win` and wrapper script on Windows CI ([#12344](https://github.com/crystal-lang/crystal/pull/12344), thanks @HertzDevil) | ||
| - [Makefile] Add format target ([#11420](https://github.com/crystal-lang/crystal/pull/11420), thanks @straight-shoota) | ||
| - Spec: bump and document timeouts in interpreted mode ([#12430](https://github.com/crystal-lang/crystal/pull/12430), thanks @asterite) |
There was a problem hiding this comment.
This PR was missing labels. It belongs into stdlib section.
Sija
reviewed
Oct 6, 2022
straight-shoota
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
I'm approving this to make it clear for merging when ready.
But it looks like https://github.com/crystal-lang/crystal/pull/12568/files#r988795474, #12568 (comment) and #12568 (comment) still need addressing.
straight-shoota
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: changelog/1.6.0/CHANGELOG.md