Codegen: fix how unions are represented to not miss bytes #12551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
|
An alternative solution, which is apparently what clang does, is to keep the union representation we had before, but whenever a union is moved we cast that union to the representation used by this PR (or a similar one) to move the bytes, so all the bytes are moved. Maybe there is a downside of representing the union like this instead of only when passing it around? That said, everything seems to be working better with this PR, so it's an improvement.
|
straight-shoota
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12550
I'm actually not sure if this is the correct solution, but... all the snippets in that issue now work fine.
See the comments in the commit for an explanation of what's done here.