[CI] Run specs in random order by default #12541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specs are currently failing due to side effects between examples. This is fixed in #12539. These side effects have been discovered through random order execution. So this already shows the benefits =) |
Sija
reviewed
Sep 29, 2022
caspiano
approved these changes
Oct 4, 2022
HertzDevil
reviewed
Oct 5, 2022
HertzDevil
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running specs in random order is better than the default lexical ordering. But it's currently not the default behaviour and thus rarely used because it needs opt-in (#12540).
This patch opts into random order execution in CI and the Makefile in general.