Introduce IO::DEFAULT_BUFFER_SIZE
#12507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
Sep 20, 2022
straight-shoota
force-pushed
the
feature/IO-DEFAULT_BUFFER_SIZE
branch
from
1902d0b to
1888445
Compare
|
Sorry for the force push. I had only checked the explicit IO specs locally (which were all good). But there were some hard coded references to the buffer size in related specs (HTTP and Unix socket). Now I fixed that and it was better to do a force push to ensure the refactored spec works with the old as well as the increased buffer size. |
bararchy
approved these changes
Sep 20, 2022
HertzDevil
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of the discussion in https://forum.crystal-lang.org/t/io-copy-buffer-too-small/1873, this patch introduces a constant
IO::DEFAULT_BUFFER_SIZEwhich holds the default size of a generic stream buffer.This size is also increased from 4K (most IO operations) and 8K (
IO::Buffered) to 32K which should be a good default for modern machines.