Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Fix call stack when executable path contains symlinks #12504

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

HertzDevil
Copy link
Contributor

This fixes call stacks on newer macOS releases for commands like crystal run. See #12332 (comment).

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:runtime platform:darwin labels Sep 19, 2022
@straight-shoota straight-shoota added this to the 1.6.0 milestone Sep 20, 2022
@Sija
Copy link
Contributor

Sija commented Sep 20, 2022

CI still fails on macOS :(

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HertzDevil 👍

@straight-shoota straight-shoota merged commit 278819e into crystal-lang:master Sep 26, 2022
@HertzDevil HertzDevil deleted the bug/macos-callstack branch September 30, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:darwin topic:stdlib:runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants