Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Colorize doc example #12492

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Fix Colorize doc example #12492

merged 1 commit into from
Sep 20, 2022

Conversation

zw963
Copy link
Contributor

@zw963 zw963 commented Sep 17, 2022

No description provided.

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs topic:stdlib:text labels Sep 17, 2022
@zw963
Copy link
Contributor Author

zw963 commented Sep 18, 2022

If we should always merge those document fix and add it into next release ASAP ?

e.g. #12343, and current PR.

My concern is, those document fix never breaking anything, right? those a very simple changes, we can always release it safely, not worry about breaking something, probably we need a individual more efficient/simple CI process for those simple doc things instead.

We have a lot of documentation need additions/fixes/improvements, better documentation is better for newcomers, i really want to help, but the current process leaves me unmotivated.

@straight-shoota @asterite @Blacksmoke16

@straight-shoota
Copy link
Member

straight-shoota commented Sep 18, 2022

Yes, this PR is a trivial fix and it should be fine to accept it without a second approval.

#12343 on the other hand is not as trivial and I think it's important to vet such documentation changes, even if it won't break any code.

It's still a very simple change, so reviewing should be pretty quick. I do not know why no other Core Team member has approved it yet.

I understand that such a long process even for simple changes can be demotivating. I'd wish we could move faster. This is a discussion for another place, though. Let's continue this on the forums.

@straight-shoota straight-shoota added this to the 1.6.0 milestone Sep 18, 2022
@straight-shoota straight-shoota merged commit 9577ba7 into crystal-lang:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs topic:stdlib:text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants