Fix homogeneous_aggregate? check for aarch64 types
#12445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blacksmoke16
added
kind:bug
Previously we recorded all return and arg types as though they weren't homogeneous aggregates. This minor changes fixes crystal-lang#12407
|
Added a test now that I got the specs to run locally. Apologies for the force push 😬 |
straight-shoota
approved these changes
Sep 5, 2022
|
Is this not going to make it in 1.5.1? |
asterite
approved these changes
Sep 7, 2022
|
@mattrberry That's a good point. I think we can still pull this into 1.5.1. It should've been released today, but I suppose we can push it a bit to incorporate this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we recorded all return and arg types as though they weren't homogeneous aggregates. This minor changes fixes #12407
Side note: This also fixes the ImGui bindings from my emulator :)