Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check abstract def parameter names on abstract types and modules #12434

Conversation

HertzDevil
Copy link
Contributor

Fixes #12266.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler labels Sep 1, 2022
@straight-shoota straight-shoota modified the milestones: 1.6.0, 1.5.1 Sep 1, 2022
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HertzDevil 🙏

@straight-shoota straight-shoota merged commit ec1349e into crystal-lang:master Sep 5, 2022
@HertzDevil HertzDevil deleted the bug/abstract-type-abstract-def-check branch September 6, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Positional parameter mismatch: warning inconsistency
3 participants