Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: bump and document timeouts in interpreted mode #12430

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

asterite
Copy link
Member

No description provided.

@straight-shoota straight-shoota added this to the 1.6.0 milestone Aug 30, 2022
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asterite 🙏

@straight-shoota straight-shoota merged commit 4d5832c into master Aug 31, 2022
@straight-shoota straight-shoota deleted the spec/interpreter-timeouts branch August 31, 2022 15:57
@HertzDevil
Copy link
Contributor

The master CI run for this very PR times out despite the increased schedule_timeout duration: https://github.com/crystal-lang/crystal/runs/8117747560?check_suite_focus=true

@asterite
Copy link
Member Author

asterite commented Sep 1, 2022

Interesting! Then probably there's a something wrong with the interpreter that makes a fiber get stuck or something. It's also interesting to that other specs continue to run fine.

@asterite
Copy link
Member Author

asterite commented Sep 1, 2022

Is there a way to make CI not consider interepeter spec failures as failing the entire PR? That is, I think the interpreter is a "nice to have" at this point, not something that required to work on releases.

@straight-shoota
Copy link
Member

No. GitHub Actions can't to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants