Warn on suffix-less integer literals outside Int64
's range
#12427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #8373 (comment). The warnings are generated in a few places:
parse_type
returns (because generic type arguments may contain large integer literals)The formatter could technically swallow the warnings and append
u64
to all the large literals, which is actually what I did with the last commit here:Some places like the compiler-rt specs add
u64
to a lot of literals regardless of whether they actually require one, because they look better.