Compiler: simplify some calls #12417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are Call constructors that take one or two call arguments. Use those instead of passing an array. I also added a new overload that takes three arguments. I think 0..3 arguments is the most common case in the compiler. This shouldn't affect anything, but it might make things a bit easier if we ever decide to change `Call@args` to another type.
asterite
commented
Aug 26, 2022
| end | ||
|
|
||
| def self.new(obj, name, arg1 : ASTNode, arg2 : ASTNode) | ||
| new obj, name, [arg1, arg2] of ASTNode | ||
| end | ||
|
|
||
| def self.new(obj, name, arg1 : ASTNode, arg2 : ASTNode, arg3 : ASTNode) |
There was a problem hiding this comment.
I know at this point we could maybe use a splat, but I'd like to avoid creating intermediate tuples. 0..3 is enough.
|
I'm wondering if we can ensure to prefer these API methods for small argument lists in the future. |
We could do that if we used a linter for the project. |
|
In any case I think we can merge this without waiting for a linter, right? |
straight-shoota
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are Call constructors that take one or two call arguments.
Use those instead of passing an array.
I also added a new overload that takes three arguments. I think
0..3 arguments is the most common case in the compiler.
This shouldn't affect anything, but it might make things a bit easier
if we ever decide to change
Call@argsto another type.