Disallow mixing of sequential and named sprintf parameters
#12402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following for
sprintf,IO#printf, andString#%:%s) and named parameters (e.g.%{foo},%<bar>s). They are detected as soon as they consume an argument.HashorNamedTuple, or a one-elementArrayorTupleof it, depending on the overload chosen.%is no longer one of the allowed field types; exactly%%must be used to print the percent sign, and other format modifiers are not allowed. This is the behavior in Ruby but not C. This is justified because format strings like%<a>%do not make any sense.The PR also lays the groundwork for #12305.