New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make `sprintf` and `String#%` ignore NaN sign bit #12400

Merged

straight-shoota merged 1 commit into crystal-lang:master from HertzDevil:bug/sprintf-nan-sign

Aug 19, 2022

Contributor

HertzDevil commented Aug 17, 2022 •

edited

Loading

Fixes #12382.

This actually implements %f and friends in String::Formatter itself so that NaNs and infinities do not use LibC.snprintf.

Note that BigFloats are not supported yet, and even if they were, they are always finite unless #11410 is implemented.


          Make sprintf and String#% ignore NaN sign bit

76a266e

HertzDevil added kind:bug topic:stdlib:numeric topic:stdlib:text labels

straight-shoota approved these changes

View reviewed changes

straight-shoota added this to the 1.6.0 milestone

straight-shoota merged commit a47a89a into crystal-lang:master

HertzDevil deleted the bug/sprintf-nan-sign branch

August 28, 2022 08:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug topic:stdlib:numeric topic:stdlib:text