Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use interpreter to run std spec tests #12355

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Use interpreter to run std spec tests #12355

merged 5 commits into from
Aug 11, 2022

Conversation

cyangle
Copy link
Contributor

@cyangle cyangle commented Aug 3, 2022

No description provided.

@cyangle cyangle marked this pull request as draft August 3, 2022 21:46
@cyangle cyangle force-pushed the std_spec_tests branch 3 times, most recently from d876bd3 to b6770cf Compare August 4, 2022 03:03
Sija
Sija reviewed Aug 4, 2022
View reviewed changes
.github/workflows/linux.yml Outdated Show resolved Hide resolved
@cyangle cyangle marked this pull request as ready for review August 4, 2022 12:29
@HertzDevil
Copy link
Contributor

Could spec/interpreter_std_spec.cr instead be generated from a script similar to spec/generate_windows_spec.sh?

asterite
asterite approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️
This is going to be very useful with moving the interpreter forward.

@asterite asterite mentioned this pull request Aug 11, 2022
Merged
@straight-shoota straight-shoota added this to the 1.6.0 milestone Aug 11, 2022
@straight-shoota straight-shoota merged commit 344addb into crystal-lang:master Aug 11, 2022
@cyangle cyangle deleted the std_spec_tests branch August 11, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:specs topic:compiler:interpreter topic:infrastructure topic:stdlib
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cyangle @HertzDevil @Sija @asterite @straight-shoota