Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter: handle missing closured struct self #12345

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

asterite
Copy link
Member

Fixes #12341

This wasn't working because I left it out while working on getting the demo running for the Crystal conference. Luckily all of the pieces were there to easily implement this.

@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:interpreter labels Jul 31, 2022
@asterite
Copy link
Member Author

asterite commented Aug 1, 2022

@straight-shoota Asking a review in case you missed it (since you already reviewed more recent PRs from me)

@straight-shoota straight-shoota added this to the 1.6.0 milestone Aug 1, 2022
@asterite asterite merged commit e260e73 into master Aug 1, 2022
@asterite asterite deleted the interpreter/missing-struct-closured-self branch August 1, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:interpreter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpreter: BUG: missing interpret assig closured instance var of pass-by-value
2 participants