Interpreter: fix as? when there's no resulting type
#12328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
|
I'd suggest adding a spec where the object type is not already nil (for example |
|
Thanks! I pushed another commit with such a spec, which didn't initially work, so I made it work. |
straight-shoota
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12327
The code was using
is_awhich required the filtered type to be not-nil. I checked codegen.cr and for a nilable cast the filtered type can be nil, and the logic is a bit different there. So I did the same here, essentially inlining part of theis_amethod, but first doing a special logic if the filtered type is nil.I also changed the code a bit to do an early return.