Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing fields to LibC::Passwd on FreeBSD #12315

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Add missing fields to LibC::Passwd on FreeBSD #12315

merged 1 commit into from
Jul 26, 2022

Conversation

dmgk
Copy link
Contributor

@dmgk dmgk commented Jul 24, 2022 •
edited by oprypin
Loading

Add missing fields and fix failing spec/std/path_spec.cr spec.

Fixes #12314

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:system platform:freebsd labels Jul 24, 2022
@straight-shoota straight-shoota linked an issue Jul 25, 2022 that may be closed by this pull request
LibC::Passwd is missing fields on FreeBSD #12314
Closed
@oprypin oprypin changed the title Add missing fields to LibC::Passwd on FreeBSD (#12314) Add missing fields to LibC::Passwd on FreeBSD Jul 25, 2022
oprypin
oprypin approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches reference https://www.freebsd.org/cgi/man.cgi?query=getpwnam&sektion=3&format=html#DESCRIPTION

@straight-shoota straight-shoota added this to the 1.6.0 milestone Jul 26, 2022
@straight-shoota straight-shoota changed the title Add missing fields to LibC::Passwd on FreeBSD Add missing fields to LibC::Passwd on FreeBSD Jul 26, 2022
@straight-shoota straight-shoota merged commit 023b01a into crystal-lang:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@oprypin oprypin oprypin approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:freebsd topic:stdlib:system
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

LibC::Passwd is missing fields on FreeBSD
4 participants
@dmgk @oprypin @straight-shoota @Blacksmoke16