Interpreter: introduce a Prompt type
#12288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
force-pushed
the
interpreter/repl-improvements
branch
from
f55b4d5 to
971a035
Compare
|
Just curious, could this also provide the ability to "up/down-arrow" for previous input? |
|
That's readline: #11340 |
straight-shoota
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prompt type helps with getting input from STDIN and it also allows for incomplete input to be handled. This was already the case when you did
crystal ibut not when in pry.Here I also decided to color the input you write after the fact. This is what Ruby's pry does, and I like it. But let me know if you don't like it! (you can always disable it with
--no-color).Pry actually also colors the output. But for that it just pretty inspects the value with a colorer-pretty-inspector. We can do the same, but in a later PR.
Here's are sample session: