Interpreter: cache methods with captured block #12285
Merged
+19
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12276
The interpreter caches method instantiations. However, it doesn't (can't) cache them if a method has an inlined-block. But a check to see that the block wasn't actually captured was missing. So this fixes that, and it might also improve the performance (previously every call to a method that captured a block was re-compiled.) It's probably unnoticeable, not sure (I didn't benchmark anything)