Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter: handle yield with splat combined with tuple unpacking #12247

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Interpreter: handle yield with splat combined with tuple unpacking #12247

merged 3 commits into from
Jul 12, 2022

Conversation

asterite
Copy link
Member

Fixes #12227

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:interpreter labels Jul 10, 2022
@cyangle
Copy link
Contributor

cyangle commented Jul 10, 2022

@asterite This PR breaks the existing interpreter tests.

@asterite
Copy link
Member Author

Thanks! I pushed a commit that should fix things.

@straight-shoota straight-shoota added this to the 1.6.0 milestone Jul 12, 2022
@asterite
Copy link
Member Author

@straight-shoota thank you for the marathon review!

@asterite asterite merged commit f59b5ae into master Jul 12, 2022
@asterite asterite deleted the interpreter/yield-splat-with-tuple-unpacking branch July 12, 2022 21:38
@straight-shoota
Copy link
Member

Thanks for your marathon patches 🙇
I just try to help you keep rolling 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:interpreter
Projects
None yet
Milestone
1.6.0
4 participants
@asterite @cyangle @straight-shoota @Blacksmoke16