Parser: Rename arg* to param*
#12235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename `parse_*arg` to `parse_*param` * Rename `arg*` to `param*` in `parse_*param`
HertzDevil
reviewed
Jul 9, 2022
Follow the suggestion in the PR review and rename more arg* vars and function names to param*.
potomak
force-pushed
the
rename-arg-to-param
branch
from
cf6d5cb to
f2647d0
Compare
There was one conditional branch in `check_not_pipe_before_proc_literal_body` that didn't have an assertion.
straight-shoota
approved these changes
Jul 9, 2022
HertzDevil
approved these changes
Sep 23, 2022
|
I think there's still a confusion here. We have a block param which is But then there's also Or would that be a block arg? I'll go with block arg for now. |
|
Actually I'll go with "def block param" for now in what I'm doing. |
|
The conclusion on the forum is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a function or block definition you can define a list of parameters. The parser implementation calls them arguments, but this name is imprecise. Here I'm updating some variable and function names to clarify a bit that they are params instead of args.
parse_*argtoparse_*paramarg*toparam*inparse_*paramSee #10374