Crystal::Loader: don't check if file exists, leave that to dlopen #12207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2022
Blacksmoke16
added
kind:bug
asterite
commented
Jul 5, 2022
| @@ -89,7 +89,7 @@ class Crystal::Loader | |||
|
|
|||
| @search_paths.each do |directory| | |||
There was a problem hiding this comment.
We could change this to @search_paths.any? but I didn't want to introduce a diff bigger than necessary here
beta-ziliani
approved these changes
Jul 5, 2022
straight-shoota
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12204
Follow-up on #12140
Same as #11852