Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix \{{...}} syntax in macro inside comments #12175

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Fix \{{...}} syntax in macro inside comments #12175

merged 2 commits into from
Jul 4, 2022

Conversation

asterite
Copy link
Member

Fixes #4380

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:lang:macros labels Jun 30, 2022
@straight-shoota straight-shoota added this to the 1.5.0 milestone Jun 30, 2022
sdogruyol
sdogruyol approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asterite 🙏

@straight-shoota straight-shoota merged commit a37e5df into master Jul 4, 2022
@straight-shoota straight-shoota deleted the parser/macro-escape-in-comment branch July 4, 2022 21:09
@jwoertink jwoertink mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:lang:macros
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Nested macros, comments, and macro variable lookup
4 participants
@asterite @straight-shoota @sdogruyol @Blacksmoke16