Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter: fix cast from virtual metaclass to union #12163

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Interpreter: fix cast from virtual metaclass to union #12163

merged 1 commit into from
Jun 28, 2022

Conversation

asterite
Copy link
Member

@asterite asterite commented Jun 26, 2022 •
edited
Loading

Fixes #12162

Bad math from my part 😅

It would be nice to merge this for 1.5 as it's a one-line fix, and it's easy to see it's correct (now with comments 😁)

@asterite asterite mentioned this pull request Jun 26, 2022
Closed
@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:interpreter labels Jun 26, 2022
straight-shoota
straight-shoota approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fixes can always be merged in the freeze period (unless there's serious concern about potential breaking changes).
Since the interpreter is still considered unstable, interpreter features should also be fine during the freeze period.

@straight-shoota straight-shoota changed the title Interpter: fix cast from virtual metaclass to union Interpreter: fix cast from virtual metaclass to union Jun 26, 2022
@straight-shoota straight-shoota added this to the 1.5.0 milestone Jun 26, 2022
sdogruyol
sdogruyol approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asterite 🙏

@straight-shoota straight-shoota merged commit cd74e1d into master Jun 28, 2022
@straight-shoota straight-shoota deleted the bug/interpreter-cast-bad-math branch June 28, 2022 20:47
asterite added a commit that referenced this pull request Jun 29, 2022
@asterite
Interpreter: fix cast from virtual metaclass to union (#12163)
f4eebeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:interpreter
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

[Interpreter] Hash#[]?(key) gives incorrect value in interpreter when hash values are classes
4 participants
@asterite @straight-shoota @sdogruyol @Blacksmoke16