Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the LLDB spec driver script #12119

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Jun 13, 2022

  • Uses bash instead of sh, since set -o is unavailable in the latter.
  • Uses the debugger intrinsic instead of setting breakpoints manually in the LLDB script. This actually also ensures all the processes eventually terminate inside the debugger.
  • Detects the LLVM version using the find-llvm-config script, required for FileCheck. Note that the LLDB and the LLVM versions need not agree, so the version suffix is not applied to the former.
  • Adds a workaround for Segmentation fault during LibGC.init #11589 where GC initialization could emit a SIGSEGV intentionally.

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the check for LLVM 14 is failing.

@straight-shoota straight-shoota added this to the 1.5.0 milestone Jun 21, 2022
@straight-shoota straight-shoota merged commit 214840f into crystal-lang:master Jun 22, 2022
@HertzDevil HertzDevil deleted the spec/lldb-driver branch June 28, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants